How EL Injection happens in Java JSF applications and how to fix it

How EL Injection Happens in Java JSF Applications and How to Fix It

Introduction

The PrimeFacesResourceProcessor.java file in the PrimeFaces Extensions library acts as a JSF PhaseListener, running before the RENDER_RESPONSE phase to resolve and apply the active UI theme. It reads a theme name from application configuration and, historically, supported EL expressions like #{themeBean.currentTheme} as values — a flexible feature that also introduced a subtle but serious security risk.

The problem lived at line 72 of PrimeFacesResourceProcessor.java, inside the beforePhase() method. The code retrieved themeParamValue from application configuration and fed it unconditionally into Jakarta EL's ExpressionFactory.createValueExpression():

ELContext elContext = context.getELContext();
ExpressionFactory expressionFactory = context.getApplication().getExpressionFactory();
ValueExpression ve = expressionFactory.createValueExpression(elContext, themeParamValue, String.class);
theme = (String) ve.getValue(elContext);

Whether themeParamValue was "saga-blue", "#{themeBean.name}", or something far more dangerous, it was handed directly to the EL engine. This unconditional evaluation is the textbook definition of an EL injection primitive.

The Vulnerability Explained

What Is EL Injection?

Java Expression Language (EL) is a powerful runtime evaluation engine built into the Jakarta EE platform. It lets you write expressions like #{user.name} or ${config.value} that are resolved against managed beans and application context at runtime. When user-controlled or externally sourced strings are passed to the EL engine without validation, an attacker who can influence that string can potentially invoke arbitrary methods, access sensitive beans, or trigger unintended application logic.

This is classified as CWE-917: Improper Neutralization of Special Elements used in an Expression Language Statement.

The Vulnerable Code

// BEFORE — vulnerable pattern at PrimeFacesResourceProcessor.java:72
String themeParamValue = applicationContext.getConfig().getTheme();

if (themeParamValue != null) {
    ELContext elContext = context.getELContext();
    ExpressionFactory expressionFactory = context.getApplication().getExpressionFactory();
    ValueExpression ve = expressionFactory.createValueExpression(elContext, themeParamValue, String.class);

    theme = (String) ve.getValue(elContext);
}

The critical issue: themeParamValue is passed to createValueExpression() regardless of whether it is an EL expression or a plain string. If themeParamValue contains #{someBean.sensitiveMethod()}, the EL engine will evaluate it without question.

How Could This Be Exploited?

Consider the attack chain:

1. An attacker finds a way to influence the theme configuration value — for example, through a misconfigured admin UI, a JNDI-sourced configuration, a properties file that is writable by a lower-privileged process, or a deserialization gadget that populates application config.
2. They set the theme parameter to something like:
   #{facesContext.getExternalContext().getApplicationMap().get('someKey')}
   or a more aggressive payload targeting the EL engine's method invocation capabilities.
3. On the next request that triggers beforePhase(), the EL engine evaluates the expression in the full application context — with access to all managed beans, the FacesContext, and the ExternalContext.

Even if direct remote write access to the config is not currently possible, this pattern is exactly the kind of exploit primitive that automated attack tools chain together with other weaknesses (like a separate configuration write vulnerability or a deserialization flaw) to achieve remote code execution. Removing it proactively raises the bar significantly.

Real-World Impact for PrimeFaces Extensions

PrimeFacesResourceProcessor runs as a PhaseListener on every JSF request lifecycle. It is not an obscure code path — it executes for every page render. If the theme value could be manipulated, the injected expression would execute in the context of the active FacesContext, giving an attacker access to the full JSF application scope, session scope, and any beans registered therein.

The Fix

What Changed

The fix, applied to PrimeFacesResourceProcessor.java, replaces the unconditional EL evaluation with an explicit input branching strategy:

// AFTER — hardened pattern
if (themeParamValue.startsWith("#{") || themeParamValue.startsWith("${")) {
    theme = context.getApplication().evaluateExpressionGet(context, themeParamValue, String.class);
}
else {
    theme = themeParamValue;
}

Three imports were also removed as they are no longer needed:

-import jakarta.el.ELContext;
-import jakarta.el.ExpressionFactory;
-import jakarta.el.ValueExpression;

Before vs. After

Why This Fix Works

The key insight is intent disambiguation: the code now explicitly asks "is this value meant to be an EL expression?" before treating it as one. Plain theme names like "saga-blue", "lara-dark-indigo", or any other string that doesn't begin with #{ or ${ are now treated as literal values and never touch the EL engine.

The fix also switches from the lower-level ExpressionFactory.createValueExpression() + ValueExpression.getValue() pattern to the higher-level Application.evaluateExpressionGet(), which is the idiomatic JSF API for one-shot expression evaluation and is easier to audit.

Key Takeaways

• ExpressionFactory.createValueExpression() is a sink: Any call to this method with a non-literal string should be treated as a potential injection point and reviewed carefully.
• Configuration values are not inherently safe: applicationContext.getConfig().getTheme() looks innocuous, but configuration can be influenced by external actors — treat it as untrusted input.
• The startsWith("#{") check disambiguates intent: It preserves the legitimate use case (EL-based theme resolution) while preventing plain strings from being evaluated as expressions.
• Removing unused EL imports reduces attack surface: Eliminating ELContext, ExpressionFactory, and ValueExpression imports signals to future developers that direct EL manipulation is intentionally avoided here.
• Exploit primitives matter even without a direct exploit: This pattern, while not independently exploitable in isolation, could be chained with a configuration write vulnerability or deserialization flaw to achieve expression evaluation under attacker control.

How Orbis AppSec Detected This

• Source: The theme parameter value retrieved from applicationContext.getConfig().getTheme() — an externally influenced configuration value in PrimeFacesResourceProcessor.java.
• Sink: expressionFactory.createValueExpression(elContext, themeParamValue, String.class) at line 72 of PrimeFacesResourceProcessor.java, where themeParamValue is passed directly to the EL engine without validation.
• Missing control: No check was performed to verify whether themeParamValue was actually an EL expression before passing it to createValueExpression(); plain strings and malicious payloads were treated identically.
• CWE: CWE-917 – Improper Neutralization of Special Elements used in an Expression Language Statement.
• Fix: Added an explicit startsWith("#{") / startsWith("${") branch so that only confirmed EL expressions are evaluated, while all other values are used as plain string literals.

Orbis AppSec automatically detected this vulnerability and opened a pull request with the fix. Try Orbis AppSec on your repositories to find and fix issues like this automatically.

Conclusion

EL injection is a subtle but serious vulnerability class in Java JSF applications. Unlike SQL injection or command injection, it doesn't always announce itself with obvious string concatenation — it can hide behind seemingly reasonable patterns like "evaluate this config value in case it's an EL expression." The vulnerability in PrimeFacesResourceProcessor.java is a perfect example: a legitimate feature (EL-based theme resolution) implemented without the guard that separates intentional EL expressions from arbitrary strings.

The fix is clean, minimal, and behavior-preserving: valid EL expressions still work, plain theme names still work, and the EL engine is no longer invoked on strings that were never meant to be expressions. If you maintain JSF applications, audit every call to createValueExpression() and evaluateExpressionGet() in your codebase — ask where each string argument comes from, and add explicit intent checks where the answer isn't "a string literal in my own code."